yiguolei commented on code in PR #29229:
URL: https://github.com/apache/doris/pull/29229#discussion_r1437754718
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -297,5 +281,121 @@ class PipScannerContext : public
vectorized::ScannerContext {
}
};
-} // namespace pipeline
-} // namespace doris
+class PipXScannerContext final : public PipScannerContext {
+ ENABLE_FACTORY_CREATOR(PipXScannerContext);
+
+public:
+ PipXScannerContext(RuntimeState* state, ScanLocalStateBase* local_state,
+ const TupleDescriptor* output_tuple_desc,
+ const RowDescriptor* output_row_descriptor,
+ const std::list<vectorized::VScannerSPtr>& scanners,
int64_t limit_,
+ int64_t max_bytes_in_blocks_queue,
+ std::shared_ptr<pipeline::ScanDependency> dependency,
+ std::shared_ptr<pipeline::Dependency> finish_dependency)
+ : PipScannerContext(state, local_state, output_tuple_desc,
output_row_descriptor,
+ scanners, limit_, max_bytes_in_blocks_queue,
dependency,
+ finish_dependency) {}
+ Status get_block_from_queue(RuntimeState* state, vectorized::BlockUPtr*
block, bool* eos,
+ int id, bool wait = false) override {
+ {
+ std::unique_lock l(_transfer_lock);
Review Comment:
line301 and line313 do not need lock 2 times.
merge these 2 code blocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
