github-actions[bot] commented on code in PR #29269:
URL: https://github.com/apache/doris/pull/29269#discussion_r1438062843
##########
be/src/olap/rowset/beta_rowset_reader.h:
##########
@@ -90,7 +90,16 @@ class BetaRowsetReader : public RowsetReader {
bool _should_push_down_value_predicates() const;
bool _is_merge_iterator() const {
return _read_context->need_ordered_result &&
- _rowset->rowset_meta()->is_segments_overlapping();
+ _rowset->rowset_meta()->is_segments_overlapping() &&
_get_segment_num() > 1;
+ }
+
+ int32_t _get_segment_num() const {
Review Comment:
warning: method '_get_segment_num' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int32_t _get_segment_num() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
