This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4634c723d7f [fix](move-memtable) only check missing tablets when
commit info is not empty (#29326)
4634c723d7f is described below
commit 4634c723d7fb86f434060c0e6fa6168d92630cb9
Author: Kaijie Chen <[email protected]>
AuthorDate: Sun Dec 31 13:50:13 2023 +0800
[fix](move-memtable) only check missing tablets when commit info is not
empty (#29326)
Some sink may not get any success tablets, because load stream will only
report them at the last CLOSE_LOAD.
For these sinks (no commit info), we should not check missing tablets since
it's expected to be empty.
---
be/src/vec/sink/writer/vtablet_writer_v2.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/sink/writer/vtablet_writer_v2.cpp
b/be/src/vec/sink/writer/vtablet_writer_v2.cpp
index 126dd4a1be0..77df9b07f18 100644
--- a/be/src/vec/sink/writer/vtablet_writer_v2.cpp
+++ b/be/src/vec/sink/writer/vtablet_writer_v2.cpp
@@ -553,9 +553,9 @@ Status VTabletWriterV2::close(Status exec_status) {
}
}
}
- if (!_missing_tablets.empty()) {
- std::stringstream ss("pre-commit check failed, ");
- ss << "missing " << _missing_tablets.size() << " tablets:";
+ if (!tablet_commit_infos.empty() && !_missing_tablets.empty()) {
+ std::stringstream ss;
+ ss << "pre-commit check failed, missing " <<
_missing_tablets.size() << " tablets:";
int print_limit = 3;
for (auto tablet_id : _missing_tablets |
std::ranges::views::take(print_limit)) {
ss << " (tablet_id=" << tablet_id;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
