github-actions[bot] commented on code in PR #28806:
URL: https://github.com/apache/doris/pull/28806#discussion_r1439030101
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -483,6 +484,19 @@ class OrcReader : public GenericReader {
int64_t get_remaining_rows() { return _remaining_rows; }
void set_remaining_rows(int64_t rows) { _remaining_rows = rows; }
+ // check if the given name is like _col0, _col1, ...
+ bool inline _is_hive1_col_name(const std::string& name) {
Review Comment:
warning: method '_is_hive1_col_name' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool inline _is_hive1_col_name(const std::string& name) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
