EmmyMiao87 commented on a change in pull request #6023:
URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r661098615
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -5545,6 +5547,76 @@ public void replayModifyTableProperty(short opCode,
ModifyTablePropertyOperation
}
}
+ public void modifyDefaultDistributionBucketNum(Database db, OlapTable
olapTable, ModifyDistributionClause modifyDistributionClause) throws
DdlException {
+ olapTable.writeLock();
+
+ try {
+ if (olapTable.isColocateTable()) {
+ throw new DdlException("Cannot change default bucket number of
colocate table.");
+ }
+
+ if (olapTable.getPartitionInfo().getType() != PartitionType.RANGE)
{
+ throw new DdlException("Only support change partitioned
table's distribution.");
+ }
+
+ DistributionInfo defaultDistributionInfo =
olapTable.getDefaultDistributionInfo();
+ if(defaultDistributionInfo.getType() != DistributionInfoType.HASH)
{
Review comment:
You should use your code format of IDE
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyDistributionClause.java
##########
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.alter.AlterOpType;
+import org.apache.doris.common.AnalysisException;
+
+// clause which is used to modify the default bucket number of hash
distribution
+// MODIFY DISTRIBUTION DISTRIBUTED BY HASH('key') BUCKETS number;
+public class ModifyDistributionClause extends AlterTableClause {
+
+ private DistributionDesc distributionDesc;
+
+ public DistributionDesc getDistributionDesc() {
+ return distributionDesc;
+ }
+
+ public ModifyDistributionClause(DistributionDesc distributionDesc) {
+ super(AlterOpType.MODIFY_DISTRIBUTION);
+ this.distributionDesc = distributionDesc;
+ this.needTableStable = false;
+ }
+
+ @Override
+ public void analyze(Analyzer analyzer) throws AnalysisException {
Review comment:
Have you checked the permissions for this operation?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -5545,6 +5547,76 @@ public void replayModifyTableProperty(short opCode,
ModifyTablePropertyOperation
}
}
+ public void modifyDefaultDistributionBucketNum(Database db, OlapTable
olapTable, ModifyDistributionClause modifyDistributionClause) throws
DdlException {
+ olapTable.writeLock();
+
+ try {
+ if (olapTable.isColocateTable()) {
+ throw new DdlException("Cannot change default bucket number of
colocate table.");
+ }
+
+ if (olapTable.getPartitionInfo().getType() != PartitionType.RANGE)
{
+ throw new DdlException("Only support change partitioned
table's distribution.");
+ }
+
+ DistributionInfo defaultDistributionInfo =
olapTable.getDefaultDistributionInfo();
+ if(defaultDistributionInfo.getType() != DistributionInfoType.HASH)
{
Review comment:
```suggestion
if (defaultDistributionInfo.getType() !=
DistributionInfoType.HASH) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
