morningman commented on a change in pull request #6079:
URL: https://github.com/apache/incubator-doris/pull/6079#discussion_r661123903
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java
##########
@@ -115,7 +114,8 @@ public static void write(DataOutput out, Type type) throws
IOException {
Preconditions.checkArgument(type.isScalarType(), "only support scalar
type serialization");
ScalarType scalarType = (ScalarType) type;
if (scalarType.getPrimitiveType() == PrimitiveType.DECIMALV2) {
- Text.writeString(out, PrimitiveType.DECIMAL.name());
+ // todo rename decimalV2 to decimal. then use
PrimitiveType.DECIMALV2.name()
+ Text.writeString(out, "DECIMAL");
Review comment:
Here we can just write DECIMALV2. And in read method, check if it is
DECIMAL or DECIMALV2
##########
File path: be/src/exprs/expr_context.cpp
##########
@@ -202,25 +202,6 @@ void ExprContext::get_value(TupleRow* row, bool as_ascii,
TColumnValue* col_val)
col_val->__set_double_val(*reinterpret_cast<double*>(value));
break;
#if 0
Review comment:
# if 0 can be removed?
##########
File path: gensrc/thrift/Types.thrift
##########
@@ -66,7 +66,7 @@ enum TPrimitiveType {
DATE,
DATETIME,
BINARY,
- DECIMAL,
+ DECIMAL_DEPRACTED, // not used now, only for place holder
Review comment:
Is it compatible to change the enum's name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
