github-actions[bot] commented on code in PR #29428:
URL: https://github.com/apache/doris/pull/29428#discussion_r1439374336
##########
be/src/runtime/group_commit_mgr.h:
##########
@@ -62,44 +64,54 @@ class LoadBlockQueue {
Status add_load_id(const UniqueId& load_id);
void remove_load_id(const UniqueId& load_id);
void cancel(const Status& st);
+ bool need_commit() { return _need_commit; }
Review Comment:
warning: method 'need_commit' can be made const
[readability-make-member-function-const]
```suggestion
bool need_commit() const { return _need_commit; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
