github-actions[bot] commented on code in PR #29437:
URL: https://github.com/apache/doris/pull/29437#discussion_r1439614273
##########
be/src/runtime/load_stream.cpp:
##########
@@ -436,13 +435,33 @@ void LoadStream::_report_schema(StreamId stream, const
PStreamHeader& hdr) {
st.to_protobuf(response.mutable_status());
buf.append(response.SerializeAsString());
- int ret = brpc::StreamWrite(stream, buf);
- // TODO: handle EAGAIN
- if (ret != 0) {
- LOG(INFO) << "stream write report schema " << ret << ": " <<
std::strerror(ret);
+ auto wst = _write_stream(stream, buf);
+ if (!wst.ok()) {
+ LOG(WARNING) << *this << " report result failed with " << wst;
}
}
+Status LoadStream::_write_stream(StreamId stream, butil::IOBuf& buf) {
Review Comment:
warning: method '_write_stream' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status LoadStream::_write_stream(StreamId stream, butil::IOBuf& buf) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
