morningman commented on a change in pull request #6230:
URL: https://github.com/apache/incubator-doris/pull/6230#discussion_r671601618
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java
##########
@@ -203,7 +203,7 @@ public TExecPlanFragmentParams plan(TUniqueId loadId)
throws UserException {
}
// get all specified partition ids.
- // if no partition specified, return all partitions
+ // if no partition specified, return null
private List<Long> getAllPartitionIds() throws DdlException,
AnalysisException {
Review comment:
You change it to return null, but don' t change the caller to handle
null? Such as in `StreamLoadPlanner`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
