JNSimba commented on a change in pull request #6243:
URL: https://github.com/apache/incubator-doris/pull/6243#discussion_r672751011
##########
File path:
extension/flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableFactory.java
##########
@@ -234,27 +239,39 @@ private DorisReadOptions
getDorisReadOptions(ReadableConfig readableConfig) {
return builder.build();
}
- private DorisExecutionOptions getDorisExecutionOptions(ReadableConfig
readableConfig) {
+ private DorisExecutionOptions getDorisExecutionOptions(ReadableConfig
readableConfig,Properties streamLoadProp) {
Review comment:
Okay, the code style will be optimized
##########
File path:
extension/flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisStreamLoad.java
##########
@@ -133,11 +141,15 @@ public void load(String value) throws StreamLoadException
{
}
private LoadResponse loadBatch(String value) {
- Calendar calendar = Calendar.getInstance();
- String label =
String.format("flink_connector_%s%02d%02d_%02d%02d%02d_%s",
- calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH) + 1,
calendar.get(Calendar.DAY_OF_MONTH),
- calendar.get(Calendar.HOUR_OF_DAY),
calendar.get(Calendar.MINUTE), calendar.get(Calendar.SECOND),
- UUID.randomUUID().toString().replaceAll("-", ""));
+ String label = streamLoadProp.getProperty("label");
+ if(StringUtils.isBlank(label)){
+ Calendar calendar = Calendar.getInstance();
+ label = String.format("flink_connector_%s%02d%02d_%02d%02d%02d_%s",
Review comment:
already modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
