github-actions[bot] commented on code in PR #29866:
URL: https://github.com/apache/doris/pull/29866#discussion_r1448531918
##########
be/src/util/jsonb_document.h:
##########
@@ -451,7 +451,7 @@ class JsonbKeyValue {
static const int sMaxKeyId = 65535;
typedef uint16_t keyid_type;
- static const uint8_t sMaxKeyLen = 64;
+ static const uint8_t sMaxKeyLen = 256;
Review Comment:
warning: implicit conversion from 'int' to 'const uint8_t' (aka 'const
unsigned char') changes value from 256 to 0
[clang-diagnostic-constant-conversion]
```cpp
static const uint8_t sMaxKeyLen = 256;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
