HappenLee commented on code in PR #29851:
URL: https://github.com/apache/doris/pull/29851#discussion_r1448784657
##########
be/src/vec/exprs/vruntimefilter_wrapper.cpp:
##########
@@ -82,20 +83,43 @@ Status VRuntimeFilterWrapper::execute(VExprContext*
context, Block* block, int*
RETURN_IF_ERROR(_impl->execute(context, block, result_column_id));
uint8_t* data = nullptr;
const ColumnWithTypeAndName& result_column =
block->get_by_position(*result_column_id);
- if (auto* nullable =
check_and_get_column<ColumnNullable>(*result_column.column)) {
+ if (is_column_const(*result_column.column)) {
+ auto const_data_column =
Review Comment:
better call get_data_at（0）? simplify the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
