morningman commented on code in PR #29291:
URL: https://github.com/apache/doris/pull/29291#discussion_r1446913837
##########
be/src/common/config.cpp:
##########
@@ -1058,6 +1058,7 @@ DEFINE_Bool(enable_feature_binlog, "false");
DEFINE_Bool(enable_set_in_bitmap_value, "false");
DEFINE_Int64(max_hdfs_file_handle_cache_num, "20000");
+DEFINE_Int64(max_hdfs_file_handle_cache_time_ms, "3600000");
Review Comment:
max_hdfs_file_handle_cache_time_sec, "3600"
##########
be/src/io/hdfs_builder.cpp:
##########
@@ -114,22 +96,23 @@ Status create_hdfs_builder(const THdfsParams& hdfsParams,
const std::string& fs_
RETURN_IF_ERROR(builder->init_hdfs_builder());
hdfsBuilderSetNameNode(builder->get(), fs_name.c_str());
// set kerberos conf
+ if (hdfsParams.__isset.hdfs_kerberos_keytab) {
+ builder->kerberos_login = true;
+ builder->hdfs_kerberos_keytab = hdfsParams.hdfs_kerberos_keytab;
+#ifdef USE_HADOOP_HDFS
+ // hdfsBuilderSetKerb5Conf(builder->get(), "/etc/krb5.conf");
Review Comment:
remove unused line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
