EmmyMiao87 commented on a change in pull request #6335:
URL: https://github.com/apache/incubator-doris/pull/6335#discussion_r677929552
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaProgress.java
##########
@@ -22,13 +22,14 @@
import org.apache.doris.common.util.DebugUtil;
import org.apache.doris.thrift.TKafkaRLTaskProgress;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
-
+import com.clearspring.analytics.util.Lists;
Review comment:
order
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -1352,36 +1353,49 @@ public String getShowCreateInfo() {
sb.append("PRECEDING FILTER
").append(precedingFilter.toSql()).append(",\n");
}
// remove the last ,
- if (",".equals(sb.charAt(sb.length() - 2))) {
+ if (sb.charAt(sb.length() - 2) == ',') {
sb.replace(sb.length() - 2, sb.length() - 1, "");
}
- // 5.job_properties
+ // 5.job_properties. See PROPERTIES_SET of CreateRoutineLoadStmt
sb.append("PROPERTIES\n(\n");
appendProperties(sb,
CreateRoutineLoadStmt.DESIRED_CONCURRENT_NUMBER_PROPERTY,
desireTaskConcurrentNum, false);
+ appendProperties(sb, CreateRoutineLoadStmt.MAX_ERROR_NUMBER_PROPERTY,
maxErrorNum, false);
appendProperties(sb,
CreateRoutineLoadStmt.MAX_BATCH_INTERVAL_SEC_PROPERTY, maxBatchIntervalS,
false);
appendProperties(sb, CreateRoutineLoadStmt.MAX_BATCH_ROWS_PROPERTY,
maxBatchRows, false);
appendProperties(sb, CreateRoutineLoadStmt.MAX_BATCH_SIZE_PROPERTY,
maxBatchSizeBytes, false);
- appendProperties(sb, CreateRoutineLoadStmt.MAX_ERROR_NUMBER_PROPERTY,
maxErrorNum, false);
- appendProperties(sb, LoadStmt.STRICT_MODE, isStrictMode(), false);
- appendProperties(sb, LoadStmt.TIMEZONE, getTimezone(), false);
appendProperties(sb, PROPS_FORMAT, getFormat(), false);
appendProperties(sb, PROPS_JSONPATHS, getJsonPaths(), false);
appendProperties(sb, PROPS_STRIP_OUTER_ARRAY, isStripOuterArray(),
false);
+ appendProperties(sb, PROPS_NUM_AS_STRING, isNumAsString(), false);
+ appendProperties(sb, PROPS_FUZZY_PARSE, isFuzzyParse(), false);
appendProperties(sb, PROPS_JSONROOT, getJsonRoot(), true);
+ appendProperties(sb, LoadStmt.STRICT_MODE, isStrictMode(), false);
+ appendProperties(sb, LoadStmt.TIMEZONE, getTimezone(), false);
+ appendProperties(sb, LoadStmt.EXEC_MEM_LIMIT, getMemLimit(), true);
sb.append(")\n");
// 6. data_source
sb.append("FROM ").append(dataSourceType).append("\n");
// 7. data_source_properties
sb.append("(\n");
getDataSourceProperties().forEach((k, v) -> appendProperties(sb, k, v,
false));
getCustomProperties().forEach((k, v) -> appendProperties(sb, k, v,
false));
- // remove the last ,
+ if (progress instanceof KafkaProgress) {
+ List<Pair<Integer, String>> pairs = ((KafkaProgress)
progress).getPartitionOffsetPairs(false);
Review comment:
Shown here is the offset specified when creating the task?
Or the offset that has already been consumed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
