github-actions[bot] commented on code in PR #29922:
URL: https://github.com/apache/doris/pull/29922#discussion_r1450191602
##########
be/src/io/fs/hdfs_file_system.cpp:
##########
@@ -104,7 +103,9 @@ class HdfsFileHandleCache {
private:
FileHandleCache _cache;
- HdfsFileHandleCache() : _cache(config::max_hdfs_file_handle_cache_num, 16,
3600 * 1000L) {}
+ HdfsFileHandleCache()
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
be/src/io/fs/hdfs_file_system.cpp:107:
```diff
- config::max_hdfs_file_handle_cache_time_sec * 1000L)
{};
+ config::max_hdfs_file_handle_cache_time_sec * 1000L)
= default;;
```
##########
be/src/io/hdfs_builder.h:
##########
@@ -56,12 +56,12 @@ class HDFSCommonBuilder {
Status init_hdfs_builder();
hdfsBuilder* get() { return hdfs_builder; }
- bool is_need_kinit() const { return need_kinit; }
- Status run_kinit();
+ bool is_kerberos() const { return kerberos_login; }
Review Comment:
warning: function 'is_kerberos' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_kerberos() const { return kerberos_login; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
