github-actions[bot] commented on code in PR #29954:
URL: https://github.com/apache/doris/pull/29954#discussion_r1451696743
##########
be/src/vec/common/unaligned.h:
##########
@@ -40,3 +41,31 @@ void unaligned_store(void* address, const typename
std::enable_if<true, T>::type
static_assert(std::is_trivially_copyable_v<T>);
memcpy(address, &src, sizeof(src));
}
+
+inline void reverse_memcpy(void* dst, const void* src, size_t size) {
+ uint8_t* uint_dst = reinterpret_cast<uint8_t*>(dst) + size; // Perform
addition here
+ const uint8_t* uint_src = reinterpret_cast<const uint8_t*>(src);
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
const auto* uint_src = reinterpret_cast<const uint8_t*>(src);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
