github-actions[bot] commented on PR #30002:
URL: https://github.com/apache/doris/pull/30002#issuecomment-1892184480
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/7529588217";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 136:
res1=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res1=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 137:
res2=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res2=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
res3=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res3=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 140:
min_value=$(echo "$res1 $res2 $res3" | tr ' ' '\n' | sort -n | head -n 1)
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
min_value=$(echo "${res1} ${res2} ${res3}" | tr ' ' '\n' | sort -n |
head -n 1)
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 141:
echo -e "q${i}:\t$res1\t$res2\t$res3\tfast:$min_value"
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^--------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
echo -e "q${i}:\t${res1}\t${res2}\t${res3}\tfast:${min_value}"
In tools/ssb-tools/bin/run-ssb-queries.sh line 149:
res1=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res1=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-queries.sh line 150:
res2=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res2=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-queries.sh line 151:
res3=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$(cat
${QUERIES_DIR}/q${i}.sql)" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
^------^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2248 (style): Prefer double quoting even when variables
don't contain special characters.
Did you mean:
res3=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}"
-D"${DB}" -e "$(cat "${QUERIES_DIR}"/q"${i}".sql)" | perl -nle 'print $1 if
/\((\d+\.\d+)+ sec\)/' || :)
In tools/ssb-tools/bin/run-ssb-queries.sh line 153:
min_value=$(echo "$res1 $res2 $res3" | tr ' ' '\n' | sort -n | head -n 1)
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
min_value=$(echo "${res1} ${res2} ${res3}" | tr ' ' '\n' | sort -n |
head -n 1)
In tools/ssb-tools/bin/run-ssb-queries.sh line 154:
echo -e "q${i}:\t$res1\t$res2\t$res3\tfast:$min_value"
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^--------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
echo -e "q${i}:\t${res1}\t${res2}\t${res3}\tfast:${min_value}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when
v...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
