luwei16 commented on code in PR #30001:
URL: https://github.com/apache/doris/pull/30001#discussion_r1452844272


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -1546,7 +1549,9 @@ public void addPartition(Database db, String tableName, 
AddPartitionClause addPa
                     olapTable.getTimeSeriesCompactionTimeThresholdSeconds(),
                     olapTable.getTimeSeriesCompactionEmptyRowsetsThreshold(),
                     olapTable.storeRowColumn(),
-                    binlogConfig, dataProperty.isStorageMediumSpecified(), 
null);
+                    binlogConfig, dataProperty.isStorageMediumSpecified(), 
null,
+                    olapTable.getTTLSeconds());
+            afterCreatePartitions(olapTable.getId(), partitionIds, indexIds);

Review Comment:
   Can beforeCreatePartitions and afterCreatePartitions be called in the 
createPartitionWithIndices function of CloudInternalCatalog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to