Gabriel39 commented on code in PR #30082:
URL: https://github.com/apache/doris/pull/30082#discussion_r1459222083
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -316,10 +317,15 @@ void TaskScheduler::_do_work(size_t index) {
PrintInstanceStandardInfo(task->query_context()->query_id(),
task->fragment_context()->get_fragment_instance_id()),
fragment_ctx->is_canceled());
- _try_close_task(task,
- fragment_ctx->is_canceled() ?
PipelineTaskState::CANCELED
- :
PipelineTaskState::FINISHED,
- status);
+ // Only meet eos, should set task to PENDING_FINISH state
+ task->set_state(PipelineTaskState::PENDING_FINISH);
Review Comment:
Why always set PENDING_FINISH?
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -414,7 +414,21 @@ Status ExchangeSinkOperatorX::sink(RuntimeState* state,
vectorized::Block* block
// 1. calculate range
// 2. dispatch rows to channel
}
- return Status::OK();
+
+ Status final_st = Status::OK();
+ if (source_state == SourceState::FINISHED) {
Review Comment:
If task stops early and never send with `source_state == FINISH` then
channels will never close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
