morningman commented on a change in pull request #6192:
URL: https://github.com/apache/incubator-doris/pull/6192#discussion_r684881534
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java
##########
@@ -121,6 +126,17 @@ public long getMaxQueryInstances() {
return commonProperties.getMaxQueryInstances();// maxQueryInstances;
}
+ public String[] getSqlBlockRules() {
+ if (this.sqlBlockRulesSplit.length != 0) {
+ return this.sqlBlockRulesSplit;
+ }
+ String sqlBlockRules = commonProperties.getSqlBlockRules();
Review comment:
This method is only protected by `readLock`, but you do write operation
here.
Why not just save the splitted rules in `commonProperties`?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -1896,6 +1899,14 @@ public long loadSmallFiles(DataInputStream in, long
checksum) throws IOException
return checksum;
}
+ public long loadSqlBlockRule(DataInputStream in, long checksum) throws
IOException {
+ if (Catalog.getCurrentCatalogJournalVersion() >=
FeMetaVersion.VERSION_103) {
Review comment:
```suggestion
if (Catalog.getCurrentCatalogJournalVersion() >=
FeMetaVersion.VERSION_104) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
