yujun777 commented on code in PR #30160:
URL: https://github.com/apache/doris/pull/30160#discussion_r1461282674
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -80,7 +80,7 @@ public CloudInternalCatalog() {
@Override
protected Partition createPartitionWithIndices(long dbId, long tableId,
String tableName,
long baseIndexId, long partitionId, String partitionName,
Map<Long, MaterializedIndexMeta> indexIdToMeta,
- DistributionInfo distributionInfo, TStorageMedium storageMedium,
ReplicaAllocation replicaAlloc,
+ DistributionInfo distributionInfo, DataProperty dataProperty,
ReplicaAllocation replicaAlloc,
Review Comment:
can delete line 89's arg 'isStorageMediumSpecified'. Inside
createPartitionWithIndices, it can get with
dataProperty.isStorageMediumSpecified()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
