github-actions[bot] commented on code in PR #30199:
URL: https://github.com/apache/doris/pull/30199#discussion_r1461323555
##########
be/src/pipeline/exec/multi_cast_data_stream_source.cpp:
##########
@@ -154,6 +154,13 @@ Status
MultiCastDataStreamSourceLocalState::init(RuntimeState* state, LocalState
return Status::OK();
}
+Status MultiCastDataStreamSourceLocalState::close(RuntimeState* state) {
Review Comment:
warning: method 'close' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/multi_cast_data_stream_source.h:119:
```diff
- Status close(RuntimeState* state) override;
+ static Status close(RuntimeState* state) override;
```
##########
be/src/pipeline/pipeline_x/local_exchange/local_exchange_source_operator.cpp:
##########
@@ -61,6 +61,12 @@ std::string LocalExchangeSourceLocalState::debug_string(int
indentation_level) c
return fmt::to_string(debug_string_buffer);
}
+Status LocalExchangeSourceLocalState::close(RuntimeState* state) {
Review Comment:
warning: method 'close' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/local_exchange/local_exchange_source_operator.h:50:
```diff
- Status close(RuntimeState* state) override;
+ static Status close(RuntimeState* state) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
