gavinchou commented on code in PR #30243:
URL: https://github.com/apache/doris/pull/30243#discussion_r1462703968
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2762,7 +2770,7 @@ protected void runAfterCatalogReady() {
};
}
- public void addFrontend(FrontendNodeType role, String host, int
editLogPort) throws DdlException {
+ public void addFrontend(FrontendNodeType role, String host, int
editLogPort, String nodeName) throws DdlException {
Review Comment:
pls make sure it is compatible with the original impl.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1276,9 +1276,17 @@ public static String genFeNodeName(String host, int
port, boolean isOldStyle) {
}
}
+ public static String genFeNodeNameFromMeta(String host, int port, long
timeMs) {
Review Comment:
is this an incompatible change to the original implementation or just
applicable to cloud mode?
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudEnv.java:
##########
@@ -18,20 +18,327 @@
package org.apache.doris.cloud.catalog;
import org.apache.doris.catalog.Env;
+import org.apache.doris.cloud.proto.Cloud;
+import org.apache.doris.cloud.proto.Cloud.NodeInfoPB;
+import org.apache.doris.common.Config;
import org.apache.doris.common.io.CountingDataOutputStream;
+import org.apache.doris.common.util.HttpURLUtil;
+import org.apache.doris.common.util.NetUtils;
+import org.apache.doris.ha.FrontendNodeType;
+import org.apache.doris.httpv2.meta.MetaBaseAction;
+import org.apache.doris.persist.Storage;
+import org.apache.doris.system.Frontend;
+import org.apache.doris.system.SystemInfoService.HostInfo;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import java.io.DataInputStream;
+import java.io.File;
import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
public class CloudEnv extends Env {
private static final Logger LOG = LogManager.getLogger(CloudEnv.class);
+ private CloudClusterChecker cloudClusterCheck;
Review Comment:
consider put a cloudsysteminfo object into CloudEnv and CloudClusterChecker
##########
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java:
##########
@@ -1155,4 +1155,18 @@ public void setInstanceStatus(InstanceInfoPB.Status
instanceStatus) {
}
this.instanceStatus = instanceStatus;
}
+
+ public Cloud.GetClusterResponse getCloudCluster(String clusterName, String
clusterId, String userName) {
Review Comment:
move it to cloudsysteminfo if it is only used in cloud mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
