This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new dd2e0ab8543 [fix](nereids)group by expr may be lost in 
EliminateGroupByConstant rule (#30274)
dd2e0ab8543 is described below

commit dd2e0ab8543150015369632107d217ace4e7447a
Author: starocean999 <[email protected]>
AuthorDate: Tue Jan 23 19:38:27 2024 +0800

    [fix](nereids)group by expr may be lost in EliminateGroupByConstant rule 
(#30274)
---
 .../apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
index e7fa14e5cb2..e683153e9a2 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
@@ -67,7 +67,7 @@ public class EliminateGroupByConstant extends 
OneRewriteRuleFactory {
                     lit = expression;
                 }
             }
-            if (slotGroupByExprs.isEmpty() && lit != null && 
aggregate.getAggregateFunctions().isEmpty()) {
+            if (slotGroupByExprs.isEmpty() && lit != null) {
                 slotGroupByExprs.add(lit);
             }
             return 
aggregate.withGroupByAndOutput(ImmutableList.copyOf(slotGroupByExprs), 
outputExprs);


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to