github-actions[bot] commented on code in PR #30511:
URL: https://github.com/apache/doris/pull/30511#discussion_r1469346306
##########
be/src/vec/exec/vpartition_sort_node.cpp:
##########
@@ -130,27 +163,26 @@
_partition_sort_info = std::make_shared<PartitionSortInfo>(
&_vsort_exec_exprs, _limit, 0, _pool, _is_asc_order, _nulls_first,
child(0)->row_desc(),
state, _runtime_profile.get(), _has_global_limit,
_partition_inner_limit,
- _top_n_algorithm, _previous_row.get(), _topn_phase);
+ _top_n_algorithm, _topn_phase);
return Status::OK();
}
-Status VPartitionSortNode::_split_block_by_partition(vectorized::Block*
input_block,
- int batch_size) {
+Status VPartitionSortNode::_split_block_by_partition(vectorized::Block*
input_block, bool eos) {
Review Comment:
warning: method '_split_block_by_partition' can be made const
[readability-make-member-function-const]
```suggestion
Status VPartitionSortNode::_split_block_by_partition(vectorized::Block*
input_block, bool eos) const {
```
be/src/vec/exec/vpartition_sort_node.h:239:
```diff
- Status _split_block_by_partition(vectorized::Block* input_block, bool
eos);
+ Status _split_block_by_partition(vectorized::Block* input_block, bool
eos) const;
```
##########
be/src/vec/exec/vpartition_sort_node.cpp:
##########
@@ -38,23 +39,59 @@
#include "vec/exprs/vexpr_context.h"
namespace doris::vectorized {
-Status PartitionBlocks::do_partition_topn_sort() {
+Status PartitionBlocks::append_block_by_selector(const vectorized::Block*
input_block, bool eos) {
+ if (blocks.empty() || reach_limit()) {
+ _init_rows = _partition_sort_info->_runtime_state->batch_size();
+ blocks.push_back(Block::create_unique(
+
VectorizedUtils::create_empty_block(_partition_sort_info->_row_desc)));
+ }
+ auto columns = input_block->get_columns();
+ auto mutable_columns = blocks.back()->mutate_columns();
+ DCHECK(columns.size() == mutable_columns.size());
+ for (int i = 0; i < mutable_columns.size(); ++i) {
+ columns[i]->append_data_by_selector(mutable_columns[i], selector);
+ }
+ blocks.back()->set_columns(std::move(mutable_columns));
+ auto selector_rows = selector.size();
+ _init_rows = _init_rows - selector_rows;
+ _total_rows = _total_rows + selector_rows;
+ _current_input_rows = _current_input_rows + selector_rows;
+ selector.clear();
+ // maybe better could change by user PARTITION_SORT_ROWS_THRESHOLD
+ if (!eos && _partition_sort_info->_partition_inner_limit != -1 &&
+ _current_input_rows >= PARTITION_SORT_ROWS_THRESHOLD &&
+ _partition_sort_info->_topn_phase != TPartTopNPhase::TWO_PHASE_GLOBAL)
{
+ create_or_reset_sorter_state();
+ RETURN_IF_ERROR(do_partition_topn_sort());
+ _current_input_rows = 0; // reset record
+ _do_partition_topn_count++;
+ }
+ return Status::OK();
+}
+
+void PartitionBlocks::create_or_reset_sorter_state() {
Review Comment:
warning: method 'create_or_reset_sorter_state' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/exec/vpartition_sort_node.h:93:
```diff
- void create_or_reset_sorter_state();
+ static void create_or_reset_sorter_state();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
