This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git
commit 0932dadcff7a1c12bb3e72d6c8668dcad6706b73 Author: zhannngchen <[email protected]> AuthorDate: Tue Jan 30 09:48:51 2024 +0800 [enhancement](log) print detail error for segment compaction failure (#30503) --- be/src/olap/rowset/beta_rowset_writer.cpp | 11 ++++++++--- be/src/olap/rowset/segcompaction.cpp | 3 ++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/be/src/olap/rowset/beta_rowset_writer.cpp b/be/src/olap/rowset/beta_rowset_writer.cpp index 04980816a5f..acc77b730ff 100644 --- a/be/src/olap/rowset/beta_rowset_writer.cpp +++ b/be/src/olap/rowset/beta_rowset_writer.cpp @@ -397,7 +397,8 @@ Status BetaRowsetWriter::_segcompaction_if_necessary() { } if (_segcompaction_status.load() != OK) { status = Status::Error<SEGCOMPACTION_FAILED>( - "BetaRowsetWriter::_segcompaction_if_necessary meet invalid state"); + "BetaRowsetWriter::_segcompaction_if_necessary meet invalid state, error code: {}", + _segcompaction_status.load()); } else if ((_num_segment - _segcompacted_point) >= config::segcompaction_batch_size) { SegCompactionCandidatesSharedPtr segments; status = _find_longest_consecutive_small_segment(segments); @@ -426,7 +427,9 @@ Status BetaRowsetWriter::_segcompaction_rename_last_segments() { } if (_segcompaction_status.load() != OK) { return Status::Error<SEGCOMPACTION_FAILED>( - "BetaRowsetWriter::_segcompaction_rename_last_segments meet invalid state"); + "BetaRowsetWriter::_segcompaction_rename_last_segments meet invalid state, error " + "code: {}", + _segcompaction_status.load()); } if (!_is_segcompacted() || _segcompacted_point == _num_segment) { // no need if never segcompact before or all segcompacted @@ -502,7 +505,9 @@ Status BetaRowsetWriter::_wait_flying_segcompaction() { LOG(INFO) << "wait flying segcompaction finish time:" << elapsed << "us"; } if (_segcompaction_status.load() != OK) { - return Status::Error<SEGCOMPACTION_FAILED>("BetaRowsetWriter meet invalid state."); + return Status::Error<SEGCOMPACTION_FAILED>( + "BetaRowsetWriter meet invalid state, error code: {}", + _segcompaction_status.load()); } return Status::OK(); } diff --git a/be/src/olap/rowset/segcompaction.cpp b/be/src/olap/rowset/segcompaction.cpp index ad3e78a6081..32ade4392b3 100644 --- a/be/src/olap/rowset/segcompaction.cpp +++ b/be/src/olap/rowset/segcompaction.cpp @@ -242,7 +242,8 @@ Status SegcompactionWorker::_do_compact_segments(SegCompactionCandidatesSharedPt auto s = _get_segcompaction_reader(segments, tablet, schema, &reader_stats, row_sources_buf, is_key, column_ids, &reader); if (UNLIKELY(reader == nullptr || !s.ok())) { - return Status::Error<SEGCOMPACTION_INIT_READER>("failed to get segcompaction reader."); + return Status::Error<SEGCOMPACTION_INIT_READER>( + "failed to get segcompaction reader. err: {}", s.to_string()); } Merger::Statistics merger_stats; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
