github-actions[bot] commented on code in PR #30574:
URL: https://github.com/apache/doris/pull/30574#discussion_r1472633922
##########
be/src/olap/rowset/segment_v2/inverted_index_cache.cpp:
##########
@@ -301,8 +88,8 @@ int64_t InvertedIndexSearcherCache::mem_consumption() {
return _policy->cache()->mem_consumption();
}
-bool InvertedIndexSearcherCache::_lookup(const
InvertedIndexSearcherCache::CacheKey& key,
- InvertedIndexCacheHandle* handle) {
+bool InvertedIndexSearcherCache::lookup(const
InvertedIndexSearcherCache::CacheKey& key,
Review Comment:
warning: method 'lookup' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/inverted_index_cache.h:114:
```diff
- bool lookup(const InvertedIndexSearcherCache::CacheKey& key,
InvertedIndexCacheHandle* handle);
+ static bool lookup(const InvertedIndexSearcherCache::CacheKey& key,
InvertedIndexCacheHandle* handle);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
