ccoffline commented on a change in pull request #6416:
URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r699046423
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -260,17 +251,11 @@ private void processModifyColumnComment(Database db,
OlapTable tbl, List<AlterCl
}
}
- public void replayModifyComment(ModifyCommentOperationLog operation) {
+ public void replayModifyComment(ModifyCommentOperationLog operation)
throws MetaNotFoundException {
Review comment:
It is considerable. But "replay" throwing any exception is an extremely
big risk, which will cause all FE crush and cannot recover. These
`MetaNotFoundException` are mostly thrown by getDb and getTable, due to the
lock inconsistence that makes editlogs out of order. Semantically, throwing
this exception means some metadata the editlog want to edit on is missing
during replay, which makes this replay unable to continue. Just like
getDb/Table, This kind of inconsistence cannot recover anyway, and these
editlogs are theoretically only affect lost metadata.
I prefer to use `MetaNotFoundException` that indicate metadata has lost
rather than other exception which may cause confuse. The inconsistence can be
checked from warning log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
