github-actions[bot] commented on code in PR #30737:
URL: https://github.com/apache/doris/pull/30737#discussion_r1475457916
##########
be/src/cloud/cloud_tablets_channel.cpp:
##########
@@ -67,13 +67,13 @@ Status CloudTabletsChannel::add_batch(const
PTabletWriterAddBlockRequest& reques
partition_ids.insert(tablet_writer_it->second->partition_id());
}
if (!partition_ids.empty()) {
- RETURN_IF_ERROR(_init_writers_by_parition_ids(partition_ids));
+ RETURN_IF_ERROR(_init_writers_by_partition_ids(partition_ids));
}
return _write_block_data(request, cur_seq, tablet_to_rowidxs, response);
}
-Status CloudTabletsChannel::_init_writers_by_parition_ids(
+Status CloudTabletsChannel::_init_writers_by_partition_ids(
Review Comment:
warning: method '_init_writers_by_partition_ids' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status CloudTabletsChannel::_init_writers_by_partition_ids(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
