HappenLee commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1477162202
##########
be/src/vec/common/format_ip.h:
##########
@@ -194,15 +194,135 @@ inline bool parseIPv4whole(const char* src, unsigned
char* dst) {
return end != nullptr && *end == '\0';
}
+/// integer logarithm, return ceil(log(value, base)) (the smallest integer
greater or equal than log(value, base)
+inline constexpr UInt32 intLog(const UInt32 value, const UInt32 base, const
bool carry) {
Review Comment:
remove the unless code inline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
