morningman commented on code in PR #30807:
URL: https://github.com/apache/doris/pull/30807#discussion_r1477697538
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/jdbc/JdbcFunctionPushDownRule.java:
##########
@@ -168,9 +171,48 @@ private static String
replaceFunctionNameIfNecessary(String func, Predicate<Stri
}
if (newFunc != null) {
functionCallExpr.setFnName(FunctionName.createBuiltinName(newFunc));
- func = functionCallExpr.getFnName().getFunction();
}
}
- return func;
+ }
+
+ // Function used to convert nereids planner's function to old planner's
function
+ private static Expr replaceGenericFunctionExpr(FunctionCallExpr
functionCallExpr, String func) {
+ Map<String, String> supportedTimeUnits = Maps.newHashMap();
Review Comment:
This should a static field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
