github-actions[bot] commented on code in PR #30949: URL: https://github.com/apache/doris/pull/30949#discussion_r1480979749
########## be/src/vec/sink/delta_writer_v2_pool.cpp: ########## @@ -30,12 +30,15 @@ DeltaWriterV2Map::DeltaWriterV2Map(UniqueId load_id, int num_use, DeltaWriterV2P DeltaWriterV2Map::~DeltaWriterV2Map() = default; -DeltaWriterV2* DeltaWriterV2Map::get_or_create( +std::shared_ptr<DeltaWriterV2> DeltaWriterV2Map::get_or_create( Review Comment: warning: method 'get_or_create' can be made static [readability-convert-member-functions-to-static] ```suggestion static std::shared_ptr<DeltaWriterV2> DeltaWriterV2Map::get_or_create( ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
