stdpain commented on a change in pull request #6622:
URL: https://github.com/apache/incubator-doris/pull/6622#discussion_r706587901
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -620,16 +616,10 @@ Status OlapScanNode::normalize_conjuncts() {
Status OlapScanNode::build_olap_filters() {
for (auto& iter : _column_value_ranges) {
- ToOlapFilterVisitor visitor;
- boost::variant<std::vector<TCondition>> filters;
- boost::apply_visitor(visitor, iter.second, filters);
-
- std::vector<TCondition> new_filters =
boost::get<std::vector<TCondition>>(filters);
- if (new_filters.empty()) {
- continue;
- }
+ std::vector<TCondition> filters;
+ std::visit([&](auto &&range) { range.to_olap_filter(filters); },
iter.second);
- for (const auto& filter : new_filters) {
+ for (const auto& filter : filters) {
_olap_filter.push_back(filter);
Review comment:
```suggestion
for (auto& filter : filters) {
_olap_filter.emplace_back(std::move(filter));
}
```
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -620,16 +616,10 @@ Status OlapScanNode::normalize_conjuncts() {
Status OlapScanNode::build_olap_filters() {
for (auto& iter : _column_value_ranges) {
- ToOlapFilterVisitor visitor;
- boost::variant<std::vector<TCondition>> filters;
- boost::apply_visitor(visitor, iter.second, filters);
-
- std::vector<TCondition> new_filters =
boost::get<std::vector<TCondition>>(filters);
- if (new_filters.empty()) {
- continue;
- }
+ std::vector<TCondition> filters;
+ std::visit([&](auto &&range) { range.to_olap_filter(filters); },
iter.second);
- for (const auto& filter : new_filters) {
+ for (const auto& filter : filters) {
_olap_filter.push_back(filter);
Review comment:
use move instead of copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
