HappenLee commented on code in PR #30926:
URL: https://github.com/apache/doris/pull/30926#discussion_r1482134659
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -174,6 +175,62 @@ class WindowFunctionDenseRank final
void deserialize(AggregateDataPtr place, BufferReadable& buf, Arena*)
const override {}
};
+struct PercentRankData {
+ int64_t rank = 0;
+ int64_t count = 0;
+ int64_t peer_group_start = 0;
+ int64_t partition_size = 0;
+};
+
+class WindowFunctionPercentRank final
+ : public IAggregateFunctionDataHelper<PercentRankData,
WindowFunctionPercentRank> {
+private:
+ inline static double _cal_percent(int64 rank, int64 total_rows) {
Review Comment:
remove the `inline`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
