Vallishp commented on code in PR #31002:
URL: https://github.com/apache/doris/pull/31002#discussion_r1483221302
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -522,8 +523,16 @@ class Suite implements GroovyInterceptable {
runAction(new BenchmarkAction(context), actionSupplier)
}
- void waitForSchemaChangeDone(Closure actionSupplier) {
+ void waitForSchemaChangeDone(Closure actionSupplier, String insertSql =
null, boolean cleanOperator = false,String tbName=null) {
runAction(new WaitForAction(context), actionSupplier)
+ if (ObjectUtils.isNotEmpty(insertSql)){
+ sql insertSql
+ }
+ if (cleanOperator==true){
+ if (ObjectUtils.isEmpty(tbName)) throw new
RuntimeException("tbName cloud not be null")
Review Comment:
I think typing mistake : cloud ==> could
May be can we change it like "Table name must not be null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
