github-actions[bot] commented on code in PR #31032:
URL: https://github.com/apache/doris/pull/31032#discussion_r1492487025
##########
be/src/io/fs/local_file_system.cpp:
##########
@@ -453,5 +456,19 @@ Status LocalFileSystem::_glob(const std::string& pattern,
std::vector<std::strin
return Status::OK();
}
+Status LocalFileSystem::permission(const Path& file, std::filesystem::perms
prms) {
+ auto path = absolute_path(file);
+ FILESYSTEM_M(permission_impl(path, prms));
+}
+
+Status LocalFileSystem::permission_impl(const Path& file,
std::filesystem::perms prms) {
Review Comment:
warning: method 'permission_impl' can be made static
[readability-convert-member-functions-to-static]
be/src/io/fs/local_file_system.h:100:
```diff
- Status permission_impl(const Path& file, std::filesystem::perms prms);
+ static Status permission_impl(const Path& file, std::filesystem::perms
prms);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
