caiconghui commented on a change in pull request #6665:
URL: https://github.com/apache/incubator-doris/pull/6665#discussion_r708865943



##########
File path: be/src/olap/tablet.cpp
##########
@@ -1345,8 +1345,8 @@ int64_t 
Tablet::prepare_compaction_and_calculate_permits(CompactionType compacti
         OLAPStatus res = _base_compaction->prepare_compact();
         if (res != OLAP_SUCCESS) {
             set_last_base_compaction_failure_time(UnixMillis());
-            
DorisMetrics::instance()->base_compaction_request_failed->increment(1);
             if (res != OLAP_ERR_BE_NO_SUITABLE_VERSION) {
+                               
DorisMetrics::instance()->base_compaction_request_failed->increment(1);

Review comment:
       ```suggestion
                
DorisMetrics::instance()->base_compaction_request_failed->increment(1);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to