gavinchou commented on code in PR #31144:
URL: https://github.com/apache/doris/pull/31144#discussion_r1495329181
##########
be/src/io/fs/s3_file_system.cpp:
##########
@@ -381,11 +381,11 @@ Status S3FileSystem::upload_impl(const Path& local_file,
const Path& remote_file
local_file.native(), full_path(key)));
}
- auto file_size = std::filesystem::file_size(local_file);
+ auto size = handle->GetBytesTransferred();
LOG(INFO) << "Upload " << local_file.native() << " to s3, endpoint=" <<
_s3_conf.endpoint
<< ", bucket=" << _s3_conf.bucket << ", key=" << key
- << ", duration=" << duration.count() << ", capacity=" <<
file_size
- << ", tp=" << (file_size) / duration.count();
+ << ", duration=" << duration.count() << ", capacity=" << size
Review Comment:
the word "capacity=" seems not accurate
also, consider change "tp=" to a more understandable name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
