xinyiZzz commented on code in PR #31001:
URL: https://github.com/apache/doris/pull/31001#discussion_r1495501101
##########
fe/fe-core/src/main/java/org/apache/doris/plsql/functions/DorisFunctionRegistry.java:
##########
@@ -207,6 +208,23 @@ private void saveInCache(String name, ParserRuleContext
procCtx) {
// cache.put(qualified(name.toUpperCase()), procCtx);
}
+ @Override
+ public void removeUserProcedure(Drop_procedure_stmtContext ctx) {
+ FuncNameInfo procedureName = new FuncNameInfo(
+
exec.logicalPlanBuilder.visitMultipartIdentifier(ctx.multipartIdentifier()));
+ if (builtinFunctions.exists(procedureName.toString())) {
+ exec.info(ctx, procedureName.toString() + " is a built-in function
which cannot be removed.");
+ return;
+ }
+ trace(ctx, "DROP PROCEDURE " + procedureName.toString());
+ removeInCache(procedureName.toString(), ctx);
Review Comment:
Why not use `DorisFunctionRegistry removeCached`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
