morrySnow commented on code in PR #31172:
URL: https://github.com/apache/doris/pull/31172#discussion_r1496850898
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ConvertJoinByCondition.java:
##########
@@ -26,26 +26,28 @@
import java.util.List;
/**
- * Convert invalid inner join to cross join.
+ * Convert join to cross join.
* Like: A inner join B on true -> A cross join B on true;
+ * Like: A left join B on true -> A cross join B on true;
* Or
* Convert invalid cross join to inner join.
* Like: A cross join B on A.id > 1 -> A inner join B on A.id > 1;
*/
-public class ConvertInnerOrCrossJoin implements RewriteRuleFactory {
+public class ConvertJoinByCondition implements RewriteRuleFactory {
Review Comment:
outer join cannot convert to cross join even condition is true. consider
left outer join with empty right child. the result is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
