github-actions[bot] commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497503521
##########
be/src/runtime/memory/cache_manager.h:
##########
@@ -54,9 +57,25 @@ class CacheManager {
void clear_once(CachePolicy::CacheType type);
+ bool need_prune(int64_t* last_timestamp, const std::string& type) {
Review Comment:
warning: method 'need_prune' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool need_prune(int64_t* last_timestamp, const std::string& type)
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
