HappenLee commented on code in PR #31171:
URL: https://github.com/apache/doris/pull/31171#discussion_r1498561660
##########
be/src/vec/data_types/serde/data_type_string_serde.h:
##########
@@ -80,6 +80,24 @@ class DataTypeStringSerDe : public DataTypeSerDe {
template <bool is_binary_format>
Status _write_column_to_mysql(const IColumn& column,
MysqlRowBuffer<is_binary_format>& result,
int row_idx, bool col_const) const;
+
+ virtual bool _is_fixed() const { return false; }
+
+ void write_to_column(IColumn& column, const char* data, size_t size) const
{
Review Comment:
should be virtual function，not use `_is_fixed()`。 so wired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
