caiconghui commented on a change in pull request #6702:
URL: https://github.com/apache/incubator-doris/pull/6702#discussion_r715277007
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java
##########
@@ -59,23 +61,19 @@ public static BackendServiceProxy getInstance() {
}
public void removeProxy(TNetworkAddress address) {
- lock.writeLock().lock();
- try {
- serviceMap.remove(address);
- } finally {
- lock.writeLock().unlock();
+ LOG.warn("begin to remove proxy: {}", address);
+ BackendServiceClient service;
+ synchronized (this) {
Review comment:
why use synchronized here and use lock for getProxy? how about use
ConcurrentHashMap and use computeIfAbsent method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
