This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 41f88ee18a7 [fix](parquet) Fix possible memory leak if 
ParquetReader::parse_thrift_footer failed (#31375)
41f88ee18a7 is described below

commit 41f88ee18a7f9c7903c85092a1c91e44816aa55e
Author: Gavin Chou <[email protected]>
AuthorDate: Sun Feb 25 10:04:35 2024 +0800

    [fix](parquet) Fix possible memory leak if 
ParquetReader::parse_thrift_footer failed (#31375)
---
 be/src/vec/exec/format/parquet/vparquet_reader.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/be/src/vec/exec/format/parquet/vparquet_reader.cpp 
b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
index dd8d01f4bb1..250604e218f 100644
--- a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
@@ -246,11 +246,10 @@ Status ParquetReader::_open_file() {
         }
         size_t meta_size = 0;
         if (_meta_cache == nullptr) {
-            RETURN_IF_ERROR(
-                    parse_thrift_footer(_file_reader, &_file_metadata, 
&meta_size, _io_ctx));
+            auto st = parse_thrift_footer(_file_reader, &_file_metadata, 
&meta_size, _io_ctx);
             // wrap it with unique ptr, so that it can be released finally.
             _file_metadata_ptr.reset(_file_metadata);
-            _file_metadata = _file_metadata_ptr.get();
+            RETURN_IF_ERROR(st);
 
             _column_statistics.read_bytes += meta_size;
             // parse magic number & parse meta data


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to