morningman commented on code in PR #31389:
URL: https://github.com/apache/doris/pull/31389#discussion_r1502297782
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java:
##########
@@ -1653,6 +1656,20 @@ private void handleShowAlter() throws AnalysisException {
resultSet = new ShowResultSet(showStmt.getMetaData(), rows);
}
+ // Show character set.
+ private void handleShowCharset() throws AnalysisException {
+ ShowCharsetStmt showStmt = (ShowCharsetStmt) stmt;
+ List<List<String>> rows = Lists.newArrayList();
+ List<String> row = Lists.newArrayList();
+ // | utf8mb4 | UTF-8 Unicode | utf8mb4_general_ci | 4|
+ row.add("utf8mb4");
Review Comment:
better use value define in `SessionVariable`, such as collationConnection,
charsetResults, charsetResults, collationDatabase, etc. You can get it from
ctx.getSessionVariables().getxxx.
And please add ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
