github-actions[bot] commented on code in PR #31487:
URL: https://github.com/apache/doris/pull/31487#discussion_r1505546015
##########
be/src/pipeline/exec/multi_cast_data_stream_sink.h:
##########
@@ -92,11 +92,16 @@ class MultiCastDataStreamSinkOperatorX final
const RowDescriptor& row_desc() const override { return _row_desc; }
- std::shared_ptr<MultiCastSharedState> create_multi_cast_data_streamer() {
- auto multi_cast_data_streamer =
+ std::shared_ptr<BasicSharedState> create_shared_state() const override {
Review Comment:
warning: method 'create_shared_state' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<BasicSharedState> create_shared_state() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
