zhannngchen commented on code in PR #31317:
URL: https://github.com/apache/doris/pull/31317#discussion_r1508851464
##########
be/src/cloud/cloud_tablets_channel.cpp:
##########
@@ -235,7 +235,16 @@ Status CloudTabletsChannel::close(LoadChannel* parent,
const PTabletWriterAddBlo
}
}
- // TODO(plat1ko): 6. set txn related delete bitmap if necessary
+ // 6. set txn related delete bitmap if necessary
Review Comment:
It's fine to add it later, or you can make some performance test on that.
In our performance optimization half a year ago, calculating delete bitmap
for incremental rowsets before commit can significantly reduce the
computational cost of the publish phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
