github-actions[bot] commented on code in PR #31526:
URL: https://github.com/apache/doris/pull/31526#discussion_r1510708475
##########
be/src/vec/aggregate_functions/aggregate_function_count.h:
##########
@@ -65,7 +65,7 @@ class AggregateFunctionCount final
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr __restrict place, const IColumn**, size_t,
Arena*) const override {
+ void add(AggregateDataPtr __restrict place, const IColumn**, ssize_t,
Arena*) const override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr __restrict place, const IColumn**,
ssize_t, Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_count.h:
##########
@@ -194,7 +194,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
```
##########
be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h:
##########
@@ -431,7 +431,7 @@
return
std::make_shared<DataTypeArray>(make_nullable(std::make_shared<DataTypeFloat64>()));
}
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Arena*) const override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -148,7 +148,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr place, const IColumn**, ssize_t,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -103,7 +103,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr place, const IColumn**, ssize_t, Arena*)
const override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_count.h:
##########
@@ -65,7 +65,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr __restrict place, const IColumn**, size_t,
Arena*) const override {
+ void add(AggregateDataPtr __restrict place, const IColumn**, ssize_t,
Arena*) const override {
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr __restrict place, const IColumn**,
ssize_t, Arena*) const override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -295,7 +295,7 @@ class AggregateJavaUdaf final
DataTypePtr get_return_type() const override { return _return_type; }
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Arena*) const override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -103,7 +103,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr place, const IColumn**, ssize_t,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -295,7 +295,7 @@
DataTypePtr get_return_type() const override { return _return_type; }
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
```
##########
be/src/vec/aggregate_functions/aggregate_function_count.h:
##########
@@ -194,7 +194,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Arena*) const override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h:
##########
@@ -386,7 +386,7 @@ class AggregateFunctionPercentile final
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeFloat64>(); }
- void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
+ void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Arena*) const override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr __restrict place, const IColumn**
columns, ssize_t row_num,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -65,7 +65,7 @@ class WindowFunctionRowNumber final
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: method 'add' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void add(AggregateDataPtr place, const IColumn**, ssize_t,
Arena*) override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -148,7 +148,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr place, const IColumn**, ssize_t, Arena*)
const override {
```
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -65,7 +65,7 @@
DataTypePtr get_return_type() const override { return
std::make_shared<DataTypeInt64>(); }
- void add(AggregateDataPtr place, const IColumn**, size_t, Arena*) const
override {
+ void add(AggregateDataPtr place, const IColumn**, ssize_t, Arena*) const
override {
Review Comment:
warning: pointer parameter 'place' can be pointer to const
[readability-non-const-parameter]
```suggestion
void add(const AggregateDataPtr place, const IColumn**, ssize_t, Arena*)
const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
