hust-hhb commented on code in PR #31757:
URL: https://github.com/apache/doris/pull/31757#discussion_r1512096934
##########
be/src/olap/wal/wal_table.cpp:
##########
@@ -263,19 +259,13 @@ Status WalTable::_handle_stream_load(int64_t wal_id,
const std::string& wal,
return st;
}
-Status WalTable::_replay_one_txn_with_stremaload(int64_t wal_id, const
std::string& wal,
+Status WalTable::_replay_one_wal_with_streamload(int64_t wal_id, const
std::string& wal,
const std::string& label) {
- bool success = false;
#ifndef BE_TEST
- auto st = _handle_stream_load(wal_id, wal, label);
- auto msg = st.msg();
- success = st.ok() || st.is<ErrorCode::PUBLISH_TIMEOUT>() ||
- msg.find("LabelAlreadyUsedException") != msg.npos;
+ return _handle_stream_load(wal_id, wal, label);
#else
- success = k_stream_load_exec_status.ok();
Review Comment:
k_stream_load_exec_status should be reserved, wal_manager_test.cpp need this
to simulate repaly wal fail case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
