morrySnow commented on code in PR #31738:
URL: https://github.com/apache/doris/pull/31738#discussion_r1512200325
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1196,10 +1198,15 @@ public PlanFragment visitPhysicalHashJoin(
.map(e -> JoinUtils.swapEqualToForChildrenOrder(e,
hashJoin.left().getOutputSet()))
.map(e -> ExpressionTranslator.translate(e, context))
.collect(Collectors.toList());
+ if (joinOperator == JoinOperator.LEFT_ANTI_JOIN) {
+ joinOperator = JoinOperator.NULL_AWARE_LEFT_ANTI_JOIN;
+ } else if (joinOperator == JoinOperator.LEFT_SEMI_JOIN) {
+ joinOperator = JoinOperator.NULL_AWARE_LEFT_SEMI_JOIN;
+ }
Review Comment:
add comment to explain why not trans join type in Nereids, and why need
trans join type here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
